enhancement: RateLimitFilter - Provides an exact rate limiting mechanism #794
Conversation
you need exact rate limiting and can accept a small decrease in efficiency, ExactRateLimiter may be an alternative option.
Chenjp
changed the title
|
minimize API change. |
|
You can't remove methods from the |
RateLimiter: keep api as stable as possible.
Updated |
There was a problem hiding this comment.
The PR makes a very large number of unnecessary changes which makes it extremely hard to review. I have already spend multiple hours just reviewing the refactoring of TimeBucketCounter.
I have yet to decide whether I will proceed with applying those changes as a first step towards to implementing the changes proposed in this PR or whether I'll opt to close this PR and request a series of smaller PRs where each PR addresses a single concern and, potentially, breaks larger, related changes into a series of smaller, reviewable commits.
| public void periodicEvict() { | ||
| final long minBucketIndex = getBucketIndex(System.currentTimeMillis()); | ||
| // assume that elapsed time of periodicEvict less than 1x bucketDuration. | ||
| // to avoid extreme case: 999999-xxx vs 1000000-xxx | ||
| final long maxBucket = minBucketIndex + 2; | ||
|
|
||
| final String minBucketPrefix = minBucketIndex + BUCKET_KEY_DELIMITER; | ||
| final String maxBucketPrefix = maxBucket + BUCKET_KEY_DELIMITER; | ||
|
|
||
| // remove obsolete items whose key are less than minBucketPrefix and maxBucketPrefix in same time. | ||
| map.keySet().removeIf(k -> k.compareTo(minBucketPrefix) < 0 && k.compareTo(maxBucketPrefix) < 0); | ||
| } |
There was a problem hiding this comment.
What problem is the change to the eviction mean to solve?
This is preparatory work for PR #794
|
It turns out the |
This is preparatory work for PR #794
This is preparatory work for PR #794
This is preparatory work for PR #794
smaller PR from #767 .
If you need exact rate limiting and can accept a small decrease in efficiency, ExactRateLimiter may be an alternative option.